Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same site cookie fix #28

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Same site cookie fix #28

merged 2 commits into from
Jan 22, 2020

Conversation

TiagoBrenck
Copy link
Contributor

Update to DotNet Framework 4.7.2
Implemented SameSiteCookieManager as suggested ms docs

Tested using Chromium 60 before and after implementation to validate the fix.

jmprieur
jmprieur approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TiagoBrenck
LGTM

@TiagoBrenck TiagoBrenck merged commit ab3e3f4 into master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@kalyankrishna1 kalyankrishna1 Awaiting requested review from kalyankrishna1

@pmaytak pmaytak Awaiting requested review from pmaytak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TiagoBrenck @jmprieur