Update prepdocs hook to use AzureDeveloperCliCredential #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongio
reviewed
Mar 14, 2023
dantelmomsft
added a commit
to dantelmomsft/azure-search-openai-demo-java
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prepdocshook usesDefaultAzureCredential, which might incorrectly use another source of auth for Azure.For example, DAC might use an environment credential that is set within the system, or the default account set for the
Azure CLI, ifazwas previously login.This change makes sure that the hook uses the same auth that was used when provisioning the template, by calling
azdfor an auth token.The
TenantIdis important to support accounts with access to multiple tenants, asazdwould returnhome-tenantif no tenant id is provided.fix: #7