Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Bullseye -> bookworm #926

Merged
merged 1 commit into from
May 16, 2024
Merged

build: Bullseye -> bookworm #926

merged 1 commit into from
May 16, 2024

Conversation

ross-p-smith
Copy link
Collaborator

@ross-p-smith ross-p-smith commented May 16, 2024 •
edited

Purpose

There was a problem with the Functions Core Tools that the compression was not working. This meant that we had to tag the version we used.

By not defining that we have to run on Bullseye and use Bookworm (debian 12) instead, we no longer need to pin that version. Testing that this works on Windows first and then seeing if we can get Mac to work on top of this.

Relates to #866

Please bear in mind that you will need to "rebuild" your devcontainer

After:

❯ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
❯ azd version
azd version 1.9.2 (commit c58b02f71710960aba28f81f3698e64cfdda9f96)
❯ func version
4.0.5700

@github-actions GitHub Actions
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL240067371% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
196 0 💤 0 ❌ 0 🔥 12.097s ⏱️

adamdougal
adamdougal approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ross-p-smith ross-p-smith added this pull request to the merge queue May 16, 2024
gaurarpit
gaurarpit approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@gaurarpit gaurarpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fingers crossed - this might fix the mac issue)

Merged via the queue into main with commit bb55bc8 May 16, 2024
12 checks passed
@ross-p-smith ross-p-smith deleted the ross/bookworm branch May 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal approved these changes

@gaurarpit gaurarpit gaurarpit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ross-p-smith @adamdougal @gaurarpit