Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating/work-with this template for GHA and Azd Devcontainer feature. #239

Closed
zedy-wj opened this issue Jul 28, 2023 · 7 comments · Fixed by #387
Closed

Updating/work-with this template for GHA and Azd Devcontainer feature. #239

zedy-wj opened this issue Jul 28, 2023 · 7 comments · Fixed by #387
Assignees
Labels
scope: deployments Deployments in Azure and CI/CD

Comments

@zedy-wj
Copy link

zedy-wj commented Jul 28, 2023

We are updating this template to support new features in Github Action.

  1. For the Github Action feature: We will remove two lines of code on container image and add GHA code after checkout step in the .github/workflow/azure-dev.yml file. (Shown as below)
image
  1. For the Azd Devcontainer feature: We will add the following code in devcontainer.json file.
"ghcr.io/azure/azure-dev/azd:latest": {}

And remove the relevant code for installing azd in post-create-command.sh file under .devcontainer folder.

curl -fsSL https://aka.ms/install-azd.sh | bash

@rajeshkamal5050 , @manekinekko , @sinedied for notification.

@SammyBloom
Copy link

Hi, please can I take on this task?

@zedy-wj zedy-wj changed the title Updating/work-with this template for GHA feature. Updating/work-with this template for GHA and Azd Devcontainer feature. Aug 23, 2023
@crazy4pi314
Copy link

@SammyBloom are you still working on this issue? If not I can help :)

@SammyBloom
Copy link

@SammyBloom are you still working on this issue? If not I can help :)
I have not been able to fix this. Please help me out. And if you don't mind, I would love to know how you fixed it when you do.

@anfibiacreativa
Copy link
Member

Closed by #384

@zedy-wj
Copy link
Author

zedy-wj commented Oct 19, 2023

@anfibiacreativa - It seems that your PR only updated the Azd Devcontainer feature, and the related feature of GHA did not seem to be updated.

manekinekko added a commit that referenced this issue Oct 19, 2023
@manekinekko
Copy link
Collaborator

Hi @zedy-wj I just opened a new PR to add the remaining changes: #387

@zedy-wj
Copy link
Author

zedy-wj commented Oct 20, 2023

Hi @manekinekko, Okay, LGTM!

manekinekko added a commit that referenced this issue Oct 20, 2023
devin-ai-integration bot pushed a commit to altsang/contoso-real-estate that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: deployments Deployments in Azure and CI/CD
Projects
None yet
5 participants