de-personalised the code from suneetnangia to azure samples #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suneetnangia
added a commit
that referenced
this pull request
Feb 17, 2023
* Added Json schema validation of publishednodes.json, with backward compatibility and jobs deserialization bug fix. * Updated with latest json schema version and removed any additional properties added previously in tests to conform to previous schema versions. * Initial implementation of json-everything as replacement for Newtonsoft Json Schema (#2). Replace Newtonsoft Schema validation with JsonSchemaDotNet. * Remove lingering references to Newtonsoft.Json.Schema library. * Remove duplicate schema file and convert to linked asset with copy always for tests. * Delete modules/src/Microsoft.Azure.IIoT.Modules.OpcUa.Publisher/src/schemas directory. GitHub seems to think this folder still exists though it is not in the repository anymore. Removing in an attempt to clean up the PR. * Revert version change to sln file, address LGTM automated review feedback. * Removed trailing whitespaces from solution by temporarily using SA1028 rule locally + added missing copyright notice. * Second Item Array Failure Schema Fix. * Add schema spec documentation. * Update schema with additional comments from code review. * Add endpoint url regex design notes to design doc. * Addressed PR review comments. * Correct typos across docs, schema and tests. * Update command line doc to include post 2.8.0 additional args. * Update Publisher* to Published* in Legacy CLI files. * Changed casing from this -> This in schema. * Revert heading changes in publisher cmd line docs. This change reverts the heading for the heading for the publisher cmd line args doc back to the original version per code upstream review comment. Co-authored-by: Suneet Nangia <suneetnangia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.