-
Notifications
You must be signed in to change notification settings - Fork 275
Edited the README.md of the 2-sign-in-b2c #423
base: main
Are you sure you want to change the base?
Conversation
@@ -81,7 +81,7 @@ or download and extract the repository *.zip* file. | |||
|
|||
```console | |||
cd ms-identity-javascript-react-tutorial | |||
cd 1-Authorization\2-sign-in-b2c\SPA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such file path existed.
@@ -81,7 +81,7 @@ or download and extract the repository *.zip* file. | |||
|
|||
```console | |||
cd ms-identity-javascript-react-tutorial | |||
cd 1-Authorization\2-sign-in-b2c\SPA | |||
cd 1-Authentication\2-sign-in-b2c\SPA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be what was intended in the README instructions.
@@ -144,7 +144,7 @@ To setup your B2C user-flows, do the following: | |||
### Step 4: Running the sample | |||
|
|||
```console | |||
cd 1-Authorization\2-sign-in-b2c\SPA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same problem here
Reason for pull requestThe instructions do not match the file structure of the project. This is what it currently says in the README: While this is the contents of the Authorization folders: None of them include the "2-sign-in-b2c\SPA" directory, while the "1-Authentication" folder contains exactly what is noted in the README. With this pull request I have changed the file paths to the supposed correct ones. TestingI have tested the code and it runs as expected, all intended functionality works. |
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information