Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Fix ingress deploy via wait loop for Stage IP #305

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

rguthriemsft
Copy link
Contributor

I ran a release against the changes and everything looks good. Should fix FW error we were seeing.

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@rguthriemsft rguthriemsft requested a review from dtzar June 18, 2019 20:05
@dtzar dtzar changed the title Fix ingress deploy. Wait for Stage IP to come online before proceeding. Fix ingress deploy via wait loop for Stage IP Jun 18, 2019
@dtzar dtzar merged commit 3af0fc2 into master Jun 18, 2019
@dtzar dtzar deleted the fix_stage_fw_rule branch June 18, 2019 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants