Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workload Identity (feature flagged) #363

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Workload Identity (feature flagged) #363

merged 3 commits into from
Sep 5, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Sep 5, 2022 •
edited
Loading

PR Summary

Lights up the enablement of Workload Identity

Closes #361

image

Feature flagged behind feature=workloadId

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

added Workload Identity
8d326b3 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 5, 2022 13:18 Inactive
added deploy param
a9b202d 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 5, 2022 14:21 Inactive
typos
8714fb3 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby temporarily deployed to azurecirgs September 5, 2022 14:46 Inactive
@Gordonby Gordonby added the feature-flagged available via feature flag label Sep 5, 2022
@Gordonby Gordonby enabled auto-merge (squash) September 5, 2022 14:48
khowling
khowling approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Gordonby Gordonby merged commit cf6317e into main Sep 5, 2022
@Gordonby Gordonby deleted the gb-workloadid branch September 5, 2022 15:16
@Gordonby Gordonby mentioned this pull request Oct 20, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees
No one assigned
Labels
feature-flagged available via feature flag helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Workload Identity
2 participants
@Gordonby @khowling