Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI bugfix, Workload Identity promoted out of featureflag #438

Merged
merged 7 commits into from
Oct 21, 2022
Merged

UI bugfix, Workload Identity promoted out of featureflag #438

merged 7 commits into from
Oct 21, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Oct 20, 2022 •
edited
Loading

PR Summary

  1. Closes Changing cards fail to update querystring #432 - UI bugfix
  2. Iterates on Workload Identity (feature flagged) #363 - Promotes feature out of feature flag to match the Public Preview status
  3. Updates K8S default version
  4. Adds AKS Resource Id as an output
  5. Terminology in readme

Workload Identity

Here's what enabling workload identity does in the cluster
image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

Gordon Byers added 4 commits October 20, 2022 15:39
update window history on card change
ea558ee
k8s default version
638fa54 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
remove workload-id feature flag
dd57a3f 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
workloadId
3fdbff6 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby self-assigned this Oct 20, 2022
aksResourceId output
8ccf04b 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby marked this pull request as ready for review October 20, 2022 15:03
@Gordonby Gordonby enabled auto-merge (squash) October 20, 2022 15:04
Gordon Byers added 2 commits October 21, 2022 12:04
Merge branch 'main' into gb-cardquerystring
a05a33c
h1 and alt tags
280609c 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 21, 2022
khowling
khowling approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ish

@Gordonby Gordonby merged commit 8f03955 into main Oct 21, 2022
@Gordonby Gordonby deleted the gb-cardquerystring branch October 21, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees

@Gordonby Gordonby

Labels
documentation Improvements or additions to documentation helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing cards fail to update querystring
2 participants
@Gordonby @khowling