To detect and show the unsupported conditions on the console banner #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyu74
changed the title
xiaoyu74
force-pushed
the
aro_checker_controller
branch
from
d822f9d
to
6c72199
Compare
xiaoyu74
changed the title
|
Please rebase pull request. |
xiaoyu74
force-pushed
the
aro_checker_controller
branch
from
6c72199
to
54a8296
Compare
xiaoyu74
force-pushed
the
aro_checker_controller
branch
5 times, most recently
from
2c809b7
to
71c3f6f
Compare
facchettos
reviewed
Jul 20, 2022
xiaoyu74
requested review from
jewzaam,
m1kola,
bennerv,
hawkowl,
rogbas,
petrkotas,
ross-bryan and
darthhexx
as code owners
xiaoyu74
changed the title
|
@xiaoyu74 I think this is looking good so far. |
|
before you spend more time on it, I think we should have a discussion about it with PMs. I had a talk with Jerome regarding some openshift version out-of-support notification and I am afraid what he told me also applies here (that we should only do AZComms). I will start a thread on slack with everyone involved |
xiaoyu74
force-pushed
the
aro_checker_controller
branch
from
8796f67
to
2535b49
Compare
facchettos
suggested changes
Dec 2, 2022
pkg/operator/controllers/checker/unsupportedconditionchecker.go
Outdated
Show resolved
Hide resolved
xiaoyu74
force-pushed
the
aro_checker_controller
branch
from
2535b49
to
9ea158d
Compare
|
Please rebase pull request. |
xiaoyu74
force-pushed
the
aro_checker_controller
branch
from
9ea158d
to
a85944c
Compare
facchettos
suggested changes
Jan 10, 2023
pkg/operator/controllers/checkers/internetchecker/unsupportconditionchecker.go
Outdated
Show resolved
Hide resolved
xiaoyu74
force-pushed
the
aro_checker_controller
branch
from
6254e10
to
3a2515a
Compare
xiaoyu74
force-pushed
the
aro_checker_controller
branch
from
3a2515a
to
c14e28f
Compare
|
there might be a |
|
s-amann
approved these changes
Feb 9, 2023
|
|
||
| func (ucc *UnsupportedConditionChecker) addConsoleBanner(ctx context.Context, consoleText string) error { | ||
| notification, err := ucc.consolecli.ConsoleV1().ConsoleNotifications().Get(ctx, consoleBannerName, metav1.GetOptions{}) | ||
| if kerrors.IsNotFound(err) { |
There was a problem hiding this comment.
this control flow is clean and easy to understand, thank you 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
To proactively detect the unsupported conditions of the ARO Cluster and show the notifications on the console banner for the end-user. The detailed description is in the task ADO-7551905
What this PR does / why we need it:
To implement an ARO operator checker to detect "unsupported conditions" and displaying the notifications on the console banner automatically. Then, make the operator marked as
upgradable=False.We haven't considered all the unsupported conditions; this PR will mainly focus on the conditions below:
less than 3 worker nodesDefault routeis configured in the ClusterCustom Network Security Groupis configured in the ClusterWe will constantly update with more conditions based on the opinions/discussions/suggestions from the team
Test plan for issue:
Testing with an ARO dev cluster to confirm the new checker is working and the notification is shown on the banner as expected.
Deploy an ARO dev cluster
In your local ARO-RP repo, run the ARO operator locally to test the new ARO checker:
oc scale -n openshift-azure-operator deployment/aro-operator-master --replicas=0CLUSTER=cluster-name go run -tags aro,containers_image_openpgp ./cmd/aro operator masterTesting the checker with the first unsupported condition which is too less worker nodes
oc scale --replicas=<number-of-replicas> machineset/<machineset-name> -n openshift-machine-apioc scale --replicas=0 machineset/shawn-dev-mbcp2-worker-australiaeast3 -n openshift-machine-apiThen, check if the notification is shown on the cluster console banner as expected. Also, the ARO operator upgradable status is set as "False"
Scale up the worker node to 3 or more and the notification should be removed from the banner
Is there any documentation that needs to be updated for this PR?
N/A - This is a new ADO task, and I will document it after the task completed and test passed.