Fix e2e test for azurefile-csi storage class that uses ARO-managed storage account on OCP 4.11 #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PVC name is a function of the StatefulSet name and the name you put in the volume claim spec: https://github.com/kubernetes/kubernetes/blob/2cb31c9333adca3f212920d7a1a4e0a3a239598d/pkg/controller/statefulset/stateful_set_utils.go#L94C3-L94C3
kimorris27
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
cadenmarchese
added
ready-for-review
chainsaw
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
force-pushed
the
fix-e2e-test-for-default-azurefile-csi-storage-class
branch
2 times, most recently
from
386723a
to
a0d1108
Compare
kimorris27
force-pushed
the
fix-e2e-test-for-default-azurefile-csi-storage-class
branch
2 times, most recently
from
b56e5d1
to
2c88a50
Compare
kimorris27
force-pushed
the
fix-e2e-test-for-default-azurefile-csi-storage-class
branch
from
2c88a50
to
65c23cf
Compare
ventifus
pushed a commit
to ventifus/ARO-RP
that referenced
this pull request
Feb 7, 2024
…orage account on OCP 4.11 (Azure#3226) * Fix PVC name in PVC status check * Limit test scope and verify that test works if FIPS is disabled * Mark test pending again, leave comment about it, and revert debugging stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-4488
What this PR does / why we need it:
This is a follow-up PR on the hotfix because we had trouble getting the test working before the hotfix release. We want this test to work so we have continuous validation that our code can handle this situation properly.
Edit: I unfortunately found that the reason that the reason the test wasn't working in CI is because CI clusters are FIPS-enabled, and Azure File storage does not work on FIPS-enabled clusters. So the plan for this PR is changing from fixing the test -> leaving the test pending but leaving comments saying it should be enabled when/if FIPS becomes toggleable post-install.
If you look at the E2E run for commit 8e39971, you can see that the test passes with FIPS disabled (though the overall E2E result was a failure for some unrelated reason).
I also fixed an issue related to the way the test gets the permanent volume - it was using the wrong name.
Test plan for issue:
The PR is for a test 😋
Is there any documentation that needs to be updated for this PR?
No