New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHIR] Install Microsoft JDK and then delete msi to decrease image size #17
[SHIR] Install Microsoft JDK and then delete msi to decrease image size #17
Conversation
@microsoft-github-policy-service agree |
BTW, I tested the resulting image |
57b4dde
to
da6a65a
Compare
Which container orchestration did you use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions and JRE/JDK installation was something to add before running this in any production workload.
Related ticket: MicrosoftDocs/azure-docs#113486
I did not add any comments for https://github.com/Azure/Azure-Data-Factory-Integration-Runtime-in-Windows-Container/pull/17/files#diff-38ab18146fe7ed8ca5f34789d90179e6212e48f778045320c3a129d18a456849R57-R59
Documentation is really bad but from SO questions, some parts of the documentation and error messages we can see that SHIR tries first to use registry keys and than JAVA_HOME
to locate java.dll. Nothing suggests that PATH
changes are needed for SHIR. If usage of $JavaHome
can be removed from build.ps1 it will significantly simplify required logic for build-time java installer selection.
@jikuja , I tested on Azure App Service on a Service Plan ith |
3c9e384
to
12d49db
Compare
12d49db
to
0ac4ee4
Compare
Hi @missingcharacter, |
I have been re-iterating this idea on my head... Would it be possible to do following:
This would make easier to extend capabilities by adding files just before build process. |
lgtm |
[SHIR] Remove SHIR msi to decrease image size
8263493
to
7a1ec12
Compare
@byran77 I've updated this PR too |
thanks @missingcharacter, it looks good. |
[SHIR] Remove SHIR msi to decrease image size
@byran77 I added docs |
Included changes: