Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] Added support for building and pushing container images to ghcr.io #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

missingcharacter
Copy link
Contributor

Why use mr-smithers-excellent/docker-build-push@v6

Why use mr-smithers-excellent/docker-build-push@v6 over docker/login-action@v2 and docker/build-push-action@v4?

docker/build-push-action@v4 does NOT support Windows builds; you can see it here: docker/build-push-action#18, while mr-smithers-excellent/docker-build-push@v6 does support windows builds.

How to push a container to a GitHub Org

diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml
index 5976088..4f1938b 100644
--- a/.github/workflows/build-docker-image.yml
+++ b/.github/workflows/build-docker-image.yml
@@ -35,5 +35,6 @@ jobs:
           image: adf-shir
           tags: ${{ steps.gen-image-tag.outputs.image_tag }}
           registry: ghcr.io
+          githubOrg: Azure
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}

@byran77
Copy link
Collaborator

byran77 commented Sep 8, 2023

thanks @missingcharacter
will start a discussion on this change.

@missingcharacter
Copy link
Contributor Author

@byran77 any news?

@byran77
Copy link
Collaborator

byran77 commented May 7, 2024

hi @missingcharacter,
sorry for the late response.
we decide to keep current status in the near future so that users can install the latest stable version in their docker image when building the docker file. We will attempt to add some automatic mechanism in SHIR release process to update the image according to your advice. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants