Pebryan/msticpy 1 0 changes 2021 03 16 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
petebryan
changed the base branch from
master
to
ianhelle/msticpy_1_0_changes-2021-03-16
…sticpy_1_0_changes-2021-03-16
…ples and SigmaRuleImporter, which seem to have got corrupted
ianhelle
reviewed
Apr 15, 2021
| @@ -87,30 +87,30 @@ | |||
| }, | |||
There was a problem hiding this comment.
I did change the version numbers to be text strings in the other notebooks but not a big deal - it works with both
Reply via ReviewNB
| @@ -104,49 +104,39 @@ | |||
| }, | |||
There was a problem hiding this comment.
We shouldn't need WIDGET_DEFAULTS any more since this is created inside init_notebook but no harm leaving it there.
Reply via ReviewNB
| @@ -136,7 +136,7 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
I moved these from the extra_imports since it's less obscure and more succinct to have them "classic-style"
Reply via ReviewNB
| @@ -39,42 +39,43 @@ | |||
| "metadata": {}, | |||
There was a problem hiding this comment.
ianhelle
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor changes to notebooks.