-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pebryan/msticpy 1 0 changes 2021 03 16 #81
Pebryan/msticpy 1 0 changes 2021 03 16 #81
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…sticpy_1_0_changes-2021-03-16
…ples and SigmaRuleImporter, which seem to have got corrupted
@@ -87,30 +87,30 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did change the version numbers to be text strings in the other notebooks but not a big deal - it works with both
Reply via ReviewNB
@@ -104,49 +104,39 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need WIDGET_DEFAULTS any more since this is created inside init_notebook but no harm leaving it there.
Reply via ReviewNB
@@ -136,7 +136,7 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved these from the extra_imports since it's less obscure and more succinct to have them "classic-style"
Reply via ReviewNB
@@ -39,42 +39,43 @@ | |||
"metadata": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various minor changes to notebooks.