Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/azure-stack-hci/cluster #929

Open
2 tasks done
mbrat2005 opened this issue May 2, 2024 · 13 comments
Open
2 tasks done

[Module Proposal]: avm/res/azure-stack-hci/cluster #929

mbrat2005 opened this issue May 2, 2024 · 13 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@mbrat2005
Copy link

mbrat2005 commented May 2, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/azure-stack-hci/cluster

Module Details

Azure Stack HCI Cluster resource

Deriving from https://github.com/Azure/azure-quickstart-templates/tree/master/quickstarts/microsoft.azurestackhci/create-cluster-with-prereqs

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

mbrat2005

(Optional) Secondary Module Owner's GitHub Username (handle)

steveswalwell

@mbrat2005 mbrat2005 added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels May 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label May 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label May 2, 2024
@matebarabas matebarabas changed the title [Module Proposal]: avm/res/azurestackhci-clusters [Module Proposal]: avm/res/azure-stack-hci/clusters May 7, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Resource Module 📦 This is a resource module labels May 7, 2024
@matebarabas matebarabas changed the title [Module Proposal]: avm/res/azure-stack-hci/clusters [Module Proposal]: avm/res/azure-stack-hci/cluster May 7, 2024
@matebarabas
Copy link
Contributor

Hi @mbrat2005,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label May 7, 2024
@mbrat2005
Copy link
Author

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels May 9, 2024
@matebarabas
Copy link
Contributor

Hi @mbrat2005,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels May 9, 2024
@mbrat2005
Copy link
Author

Working on a bicep template to deploy the prereqs for an Azure Stack HCI cluster running in Azure to enable a testing pipeline. Once completed, I will prioritize the #929 module before moving to Arc VM related modules

@mbrat2005
Copy link
Author

Hi @matebarabas - I'm continuing work on this module and have a testing pipeline completed. For the testing pipeline, the prereq deployment is complex and I'd like to avoid maintaining multiple copies of the same code for each test and other related modules with the same prereqs. Right now, I am throwing them under ./tests/modules. https://github.com/mbrat2005/bicep-registry-modules/tree/mtb-azure-stack-hci-cluster/avm/res/azure-stack-hci/cluster/tests

Do you have thoughts on how I might implement reuse here and meet the spec? One thought would be publish the prereqs as a separate pattern module, but the public value (at least for parts) may be limited. Is there somewhere else I could publish and maintain this?

@matebarabas
Copy link
Contributor

Thanks for the update, @mbrat2005! I'd like to ask the @Azure/avm-core-team-technical-bicep to comment on your question on how a solution deploying prerequisites could be best reused across multiple modules.

@mbrat2005
Copy link
Author

mbrat2005 commented May 30, 2024 via email

@mbrat2005
Copy link
Author

This is blocked by #1029

@mbrat2005
Copy link
Author

microsoft/PSRule#1864

@mbrat2005
Copy link
Author

No longer blocked by underscores in property names, but waiting on Azure/PSRule.Rules.Azure#2966 in release 1.38.0 of PSRule.Rules.Azure

@mbrat2005
Copy link
Author

Blocked by: Azure/bicep-registry-modules#3101

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Aug 5, 2024
@mbrat2005
Copy link
Author

Unblocked now that customer CI secret solution is merged

@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Status: In development
Development

No branches or pull requests

2 participants