#Issue155: Remove all unnecessary parametersets #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangshayu, |
RobinBao
reviewed
Apr 27, 2017
Infrastructure/AzureStack.Infra.psm1
Outdated
| [ValidateNotNullorEmpty()] | ||
| [String] $tenantId, | ||
|
|
||
| [Parameter(ParameterSetName='GetAlert')] | ||
| [System.Management.Automation.PSCredential] $azureStackCredentials, |
There was a problem hiding this comment.
still need [Parameter(Mandatory=$true)]. And add "[ValidateNotNull()]" for consistency with other functions.
RobinBao
approved these changes
May 2, 2017
|
@wangshayu, |
esthermiao
reviewed
May 4, 2017
| [string] $EnvironmentName, | ||
|
|
||
| [Parameter(ParameterSetName='closealert')] | ||
| [Parameter(Mandatory=$false)] |
esthermiao
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Close-AzSAlert failed because of the parameter set is not written correctly, and actually all parameter set in this file are useless. Removed them to avoid similar errors in the future