fixed Create Entity Response to begin to conform to Azure Storage Res… #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse, we might need to do some more work here, but this should be enough for basic API functionality
pmanlukas
approved these changes
Aug 30, 2018
swissarmykirpan
pushed a commit
to swissarmykirpan/Azurite
that referenced
this pull request
Sep 2, 2018
…ponse, we might need to do some more work here, but this should be enough for basic API functionality (Azure#83)
edwin-huber
added a commit
that referenced
this pull request
Sep 4, 2018
* Fix an issue with CORS when a preflight request has an empty headers list. Without this fix, azurite would fail because it was trying to call request.httpProps[N.ACCESS_CONTROL_REQUEST_HEADERS].toLowerCase() which will result in trying to call undefined.toLowerCase() if the preflight request doesn't specify access-control-request-headers. In addition, when validating a request against the CORS, the request would fail to be validated if access-control-request-headers was empty. * fixed so that when requesting single entity with PartitionKey and RowKey the emulator responds in the same way that the real azure table * Always set the copyProgress field. * Entity generator now accepts optional partition and row key * Dockerfile: deterministic builds Use explicit version tag 10.6-alpine instead of alpine to ensure a known version is used. Copy package-lock.json before npm install to ensure known dependencies are installed. * Fixed #47 Copied blob has incorrect content type * Update release-notes.md * Added Azure/azure-storage-node as test submodule Tests from azure-storage-node are invoked via test/azure-storage-shim.js for direct npm run test support. Submodule needs to be initialized with git submodule update --init first. * Fix environment variable configuration Added env-cmd package and test/.env to automatically set envs for testing. * Fix NOCK_OFF env and separate test folders * Focus on test subset for easier fixing * Updates to testing, requires changes to vscode launch.json with correct env args for each storage-node test, to ensure no nock etc * Updated documentation for Azure storage testing * Update azure-storage-node_tdd.md * Updates to Table Storage API and associated tests (#78) * Updated Readme and Package files * Updates to table storage API and created corresponding tests using Azure-storage-node, this will form the basis of fixing further table API issues currently logged * fixed up singleEntity response for QueryEntites action to return to method used by Karl Persson * small correction to test logic * Fixes for table queries not returning 404 for missing entities (#80) * Updated Readme and Package files * Updates to table storage API and created corresponding tests using Azure-storage-node, this will form the basis of fixing further table API issues currently logged * fixed up singleEntity response for QueryEntites action to return to method used by Karl Persson * small correction to test logic * Changes to correctly return 404 for missing entities and failed queries. * Updates errorCodes with EntityNotFound, updated tests * minor updates to obj assignments * added test to validate insertEntity returns Etag in metadata * added jsHint config * Updated table service error codes * Corrected a few variable definitions let vs const * Prettier Config for pull request * fixed Create Entity Response to begin to conform to Azure Storage Response, we might need to do some more work here, but this should be enough for basic API functionality (#83) * Update .prettierrc.json * now everything is pretty, but still needs some refactoring * Revert "now everything is pretty, but still needs some refactoring" This reverts commit 4524b3b. Need to rebase on dev branch before making super pretty... * rebased onto dev and then pretified * package.json update * Prettier applied to conflicting files
gpatryk
pushed a commit
to gpatryk/Azurite
that referenced
this pull request
Dec 7, 2018
…ponse, we might need to do some more work here, but this should be enough for basic API functionality (Azure#83)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for the createEntity response, which was not returning the correct attributes or status on creation of entities.