Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Make account list favorites accessible + show flag for location #1627

Merged
merged 10 commits into from
Sep 24, 2018

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Sep 24, 2018

fix #1626
image

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #1627 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1627      +/-   ##
==========================================
+ Coverage   62.63%   62.65%   +0.02%     
==========================================
  Files        1221     1224       +3     
  Lines       28834    28856      +22     
  Branches     4448     4449       +1     
==========================================
+ Hits        18059    18081      +22     
  Misses      10745    10745              
  Partials       30       30
Impacted Files Coverage Δ
...ces/monitoring/metrics/insights-metrics.service.ts 90.9% <ø> (-0.4%) ⬇️
app/components/common/index.ts 100% <100%> (ø) ⬆️
...components/account/browse/account-browse.module.ts 100% <100%> (ø) ⬆️
app/components/common/location/index.ts 100% <100%> (ø)
...p/components/common/location/location.component.ts 100% <100%> (ø)
app/components/common/location/location.module.ts 100% <100%> (ø)
app/components/common/common.module.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025a2fd...6d0cd8e. Read the comment docs.

@timotheeguerin timotheeguerin merged commit e3284ed into master Sep 24, 2018
@timotheeguerin timotheeguerin deleted the fix/account-list-style branch September 24, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account list favorite not accessible
1 participant