Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet upgrade fix #108

Merged
merged 58 commits into from
Dec 15, 2022
Merged

Dotnet upgrade fix #108

merged 58 commits into from
Dec 15, 2022

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Nov 20, 2022 •
edited

Thanks @elenavillamil heaps for suggesting the fix. Thank you @pkoelbl for creating this PR.

Thank you @GatoonJin and team for testing effort.

This PR from the main PR plus the following fixes

  • for control port stop issue
  • routing manager launch issue
  • endpoint manager launch issue

Thanks everyone who have checked this PR.

pkoelbl and others added 30 commits August 27, 2022 02:26
@pkoelbl
update to .net6
360ab12 
fix build errors
fix test
@pkoelbl
update docker files to 6.0 images
b90b541
@pkoelbl
updated samples to 6.0
f961a04
@pkoelbl
change to use kubectl apk
66c632a
@pkoelbl
remove generated json files, removed weird characters from proj file,…
ff5450d 
… removed default version
@pkoelbl
Merge pull request #1 from pkoelbl/net6
e110a03 
Net6
@pkoelbl
Merge branch 'Azure:main' into main
8c6bb76
@pkoelbl
6.0 changes
5f800b8
@pkoelbl
Merge branch 'main' of https://github.com/pkoelbl/Bridge-To-Kubernetes
e201d74
@pkoelbl
more 6.0 things
c47bd37
@pkoelbl
6.0 changes
f634903
@pkoelbl
more 6.0
35136d3
@pkoelbl
Merge branch 'main' of https://github.com/Azure/Bridge-To-Kubernetes …
4b03539 
…into Azure-main
@pkoelbl
Merge branch 'Azure-main'
bed3fbf
@pkoelbl
update sample to 6.0
8700d9c
@pkoelbl
Merge branch 'Azure:main' into main
dddab8b
@hsubramanianaks
Add check for port number
43676a4
@hsubramanianaks
Port issue (#16)
2e23490
@hsubramanianaks
Merge branch 'Azure:main' into main
81b9e98
@hsubramanianaks
Merge branch 'main' of github.com:hsubramanianaks/Bridge-To-Kubernete…
f9b7200 
…s into main
@hsubramanianaks
Add logs and correct the condition for port issue
ca7f10f
@hsubramanianaks
Resolve conflict
acf5b1c
@hsubramanianaks
change varible from var to string
e5c5d6e
@hsubramanianaks
Merge branch 'main' into main
3328170
@hsubramanianaks
Merge branch 'main' into main
648bc01
@hsubramanianaks
Merge branch 'main' into main
f181774
@pkoelbl
Merge pull request #3 from Azure/main
e67467b 
Fixing port assignment for headless service (#78)
@pkoelbl
ensure pull down of correct binaries for arm64
2e10cad
@pkoelbl
Merge branch 'main' of https://github.com/pkoelbl/Bridge-To-Kubernetes
06b9783
@pkoelbl
Merge branch 'main' into main
545d235
bfoley13
bfoley13 previously approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@hsubramanianaks hsubramanianaks mentioned this pull request Dec 14, 2022
Closed
elenavillamil
elenavillamil approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@elenavillamil elenavillamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

elenavillamil
elenavillamil previously approved these changes Dec 15, 2022
View reviewed changes
Tatsinnit
Tatsinnit previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️💡☕️🎉 Thank you so much for adding me to Thai review, it’s a huge PR and given you have dev tested I am sure all this will rock up awesomely.

I just had few observations to share hence few comments, thank you so much.

build/setup-alpine-tools.sh Outdated Show resolved Hide resolved
samples/todo-app/stats-api/.vscode/tasks.json Show resolved Hide resolved
src/LocalAgent/Dockerfile_ Outdated Show resolved Hide resolved
src/dsc/Properties/launchSettings.json Outdated Show resolved Hide resolved
Tatsinnit
Tatsinnit approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️☕️🎊🚀

@elenavillamil elenavillamil merged commit 3770b52 into Azure:main Dec 15, 2022
@sabbour
Copy link
Collaborator

sabbour commented Dec 19, 2022

Does this close any of those issues?
#112
#99
#98
#113

@hsubramanianaks
Copy link
Collaborator Author

hsubramanianaks commented Dec 19, 2022 •
edited

Yes it fixes except Issue #113. None of the fixes is not deployed to production, just in development. so, we can close once it is in production.

For 113 we have a separate PR - #124

@sabbour
Copy link
Collaborator

sabbour commented Jan 20, 2023

Closes issue #42

@hsubramanianaks hsubramanianaks deleted the dotnet-upgrade-fix branch March 8, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoelbl pkoelbl pkoelbl left review comments

@elenavillamil elenavillamil elenavillamil approved these changes

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@sabbour sabbour sabbour left review comments

@bfoley13 bfoley13 bfoley13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hsubramanianaks @sabbour @bfoley13 @elenavillamil @pkoelbl @Tatsinnit