New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom contract resolvers to handle STJ property name attributes #124
Added custom contract resolvers to handle STJ property name attributes #124
Conversation
@microsoft-github-policy-service agree [company="default"] |
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markphillips100 Thank you for the PR. I appreciate it.
ValidateDateTimeFormatForDefaultDateTimeString - this UT is not failing in our CI/CD pipelines, and I manually tested them in my local which doesn't fail either. It Should be something related to your local machine.
we will review your changes further and let you know.
Thanks,
Hari
@hsubramanianaks out of curiosity, are you (and your devops pipelines) in the UK? I'm east coast Australia and for my local windows 11 tests the If I convert the parsed datetime to universal time then the extension works as intended:
|
Is someone else going to merge the latest changes? Also, any chance this can be reviewed and released soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you very much for your PR. I have left some small comments. The main changes look good!
Hi @markphillips100, sorry for the delay we were focused on the switch to dotnet6. We have had some time in the past couple days to look at this PR and once we get green light from our testing team Monday we should be able to merge it. If you can remove the launchSettings.json file it would be ideal, but it is not a big issue if it stays. |
Azure#124) * Added custom contract resolvers to handle STJ property name attributes * Help from the PR Comments. * Removing unwnated file checkin by OP. * add ash shell for alpine back. * remove unwanted file. Co-authored-by: Mark Phillips <mark_phillips21@hotmail.com> Co-authored-by: Hariharan Subramanian <105889062+hsubramanianaks@users.noreply.github.com> Co-authored-by: elenavillamil <mariaelena.villamil.rodriguez@gmail.com> Co-authored-by: Tatsinnit <Tatsinnit@users.noreply.github.com>
….NET.Test.Sdk-17.8.0 Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.8.0 in /src
This PR fixes #113 by adding 2 new Json.Net contract resolvers to replace usage of existing
DefaultContractResolver
andCamelCasePropertyNamesContractResolver
implementations. Their primary purpose being to retain the existing camel casing behaviour or not as required, with support for deserializing property names where the property is using aSystem.Text.Json.Serialization.JsonPropertyNameAttribute
.Some notes:
PropertyIgnoreSerializerContractResolver
as was unsure of the impact.ValidateDateTimeFormatForDefaultDateTimeString()
.