implemented EmbeddedChannel, LengthFieldPrepender, LengthFieldDecoder, and more #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// </summary> | ||
| public static int SwapInt(int value) | ||
| { | ||
| byte[] bytes = BitConverter.GetBytes(value); |
There was a problem hiding this comment.
please replace with in-place bit shift-based operations, Check http://referencesource.microsoft.com/#System/net/System/Net/IPAddress.cs,aa84b64c78670092 (#else part)
|
I went through a good part today, will do the rest tomorrow. |
Aaronontheweb
force-pushed
the
lengthframedecodertests
branch
from
5f822dd
to
a52563e
Compare
|
Updated with latest changes |
Aaronontheweb
force-pushed
the
lengthframedecodertests
branch
from
a52563e
to
abfe254
Compare
| { | ||
| IRunnable task = this.PollScheduledTask(time); | ||
| if (task == null) | ||
| return this.NextScheduledTaskNanos(); |
brought AbstractContextHandler up to code EmbeddedChannelTest passes fixed LengthFieldBasedFrameDecoder finished LengthFieldPrepender finished SwappedByteBuffer
Aaronontheweb
force-pushed
the
lengthframedecodertests
branch
from
abfe254
to
2f3cef4
Compare
|
@nayato reformatted all code and changed the access modified on |
nayato
added a commit
that referenced
this pull request
Nov 5, 2015
implemented EmbeddedChannel, LengthFieldPrepender, LengthFieldDecoder, and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat large pull request because I needed to port over a bunch of pieces of infrastructure in order to match Netty's test suite...
SwappedByteBufferand implemented necessary tests and TO-DOs insideAbstractByteBufferByteBufferUtilto supportSwappedByteBufferAtomicReferenceto DotNetty.Common.Utilities from HeliosDotNetty.Common.Concurrency.AbstractEventExecutorandDotNetty.Common.Concurrency.AbstractScheduledEventExecutor- extracted a lot of stuff out ofSingleThreadedEventExecutorin order to make that happen. Will need to integrate those changes back into it.AbstractChannelHandlerContextand deletedPipelinePropagationAttributesince we now use the same bitmasking schema that Netty does.EmbeddedChannel(Implement EmbeddedChannel #3),EmbeddedEventLoop, andEmbeddedSocketAddressDotNetty.Transport.Testsand ported all of theEmbeddedChanneltests that I can without implementing IEventLoop.Schedule needs to return a Task #35LengthFrameDecoderTestsandLengthFieldPrependerTestsand have both passing.LengthFieldPrependerThis pull request should make DotNetty wire-format compatible with Helios, which would allow for replacing the latter with the former inside Akka.NET. I haven't tested that yet, but it should be easily doable now.