Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #472 #473

Merged
merged 6 commits into from
Oct 21, 2019
Merged

Fix issue #472 #473

merged 6 commits into from
Oct 21, 2019

Conversation

yyjdelete
Copy link
Contributor

No description provided.

@yyjdelete
Align and add some missing overloads for ByteBuffer
efa4007 
Add the workaroud for case 1 in Azure#436
@yyjdelete
Remove Deque.cs from DotNetty.Common
d0bc1fb 
It used to be a part of ResourceLeakDetector, but not used anymore and not an public API of DotNetty.
@yyjdelete
Fix false positive resource leak report.
12f175f
@yyjdelete
Change some behavior of ResourceLeakDetector
1ed1646
@yyjdelete
Copy link
Contributor Author

yyjdelete commented Apr 3, 2019 •
edited
Loading

Behavior changes:

Add some missing overloads for *LeakAwareByteBuffer and WrappedCompositeByteBuffer. And remove virtual from SetUnsignedShort/SetUnsignedShortLE in AbstractByteBuffer to match other Unsigned methods, which not exists in netty. Not sure if this affacts some codes.

The last commit disable ReportLeak if no logger is available, and properly record the created place of DefaultResourceLeak, like it does in new versions of netty. And change ToString() to Dump() to make debugger happy.

@nayato nayato merged commit d4bb7ae into Azure:dev Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayato nayato nayato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yyjdelete @nayato