Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(designer): Deleting a scope node brings panel to wrong id #4726

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix(designer): Deleting a scope node brings panel to wrong id #4726

merged 1 commit into from
Apr 29, 2024

Conversation

Eric-B-Wu
Copy link
Contributor

@Eric-B-Wu Eric-B-Wu commented Apr 28, 2024 •
edited
Loading

very small change to use scopeId instead as the id has an idTag and isn't one of the nodeIds

@Eric-B-Wu Eric-B-Wu merged commit c0573d1 into main Apr 29, 2024
12 checks passed
@Eric-B-Wu Eric-B-Wu deleted the eric/deletescopemodal branch April 29, 2024 12:16
Eric-B-Wu added a commit that referenced this pull request Apr 29, 2024
@Eric-B-Wu
fix(designer): Deleting a scope node brings panel to wrong id (#4726)
6f0db3f 
very small commit
@Eric-B-Wu Eric-B-Wu mentioned this pull request Apr 29, 2024
Merged
Eric-B-Wu added a commit that referenced this pull request Apr 29, 2024
@Eric-B-Wu
fix(designer): Cherry-pick hotfixes for scopes/customcode (#4730)
0c5367b 
* fix(designer): More Custom Code improvements (#4720)

even more!

* fix(Designer): Copy Paste Fixes (#4725)

* fixScopePaste

* remove logs

* fix test

* fix tests

* i forgot to update the original one

* fix(designer): Deleting a scope node brings panel to wrong id (#4726)

very small commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartra344 hartra344 hartra344 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eric-B-Wu @hartra344