Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(designer): More Custom Code improvements #4720

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix(designer): More Custom Code improvements #4720

merged 2 commits into from
Apr 26, 2024

Conversation

Eric-B-Wu
Copy link
Contributor

  1. Updating Token Picker Results based on Demo Comments
  2. Updating Boilerplate Code based on Demo Comments
  3. Removed customcode initialization/add connector-specifc code and changed to be based on parameter
  4. Changed Initialization to be off of CodeFile location instead of NodeId

@Eric-B-Wu Eric-B-Wu merged commit ecbcbfe into main Apr 26, 2024
11 checks passed
@Eric-B-Wu Eric-B-Wu deleted the eric/moreCustomCode2 branch April 26, 2024 16:40
Eric-B-Wu added a commit that referenced this pull request Apr 29, 2024
@Eric-B-Wu
fix(designer): More Custom Code improvements (#4720)
101e420 
even more!
@Eric-B-Wu Eric-B-Wu mentioned this pull request Apr 29, 2024
Merged
Eric-B-Wu added a commit that referenced this pull request Apr 29, 2024
@Eric-B-Wu
fix(designer): Cherry-pick hotfixes for scopes/customcode (#4730)
0c5367b 
* fix(designer): More Custom Code improvements (#4720)

even more!

* fix(Designer): Copy Paste Fixes (#4725)

* fixScopePaste

* remove logs

* fix test

* fix tests

* i forgot to update the original one

* fix(designer): Deleting a scope node brings panel to wrong id (#4726)

very small commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rllyy97 rllyy97 rllyy97 approved these changes

@takyyon takyyon takyyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eric-B-Wu @takyyon @rllyy97