Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP -> HTTPS redirection on App Gateway config #102

Closed
hosungsmsft opened this issue May 10, 2018 · 3 comments · Fixed by #175
Closed

Add HTTP -> HTTPS redirection on App Gateway config #102

hosungsmsft opened this issue May 10, 2018 · 3 comments · Fixed by #175
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hosungsmsft
Copy link

#98 added the Azure App Gateway support (fixing #31), but it lacks the http://siteurl -> https://siteurl redirection, which should be very easy with an Azure App Gateway example (doc). Community contribution would be great on things like this.

@hosungsmsft hosungsmsft added enhancement New feature or request good first issue Good for newcomers labels May 10, 2018
@ChrisLopezUK
Copy link

Hi @hosungsmsft. I think I have nailed this issue.

In addition I ammended the templates to allow for a conditional AppGW V2 deployment (which is a huge improvement over V1).

Not sure how to contribute. I took a clone of the repo and made a separate branch. Not sure what to do now. Any tips?

@hosungs
Copy link
Contributor

hosungs commented Mar 2, 2020

Hi @hosungsmsft. I think I have nailed this issue.

In addition I ammended the templates to allow for a conditional AppGW V2 deployment (which is a huge improvement over V1).

Not sure how to contribute. I took a clone of the repo and made a separate branch. Not sure what to do now. Any tips?

Sorry @ChrisLopezUK , I no longer work at Microsoft on this project. @rgardler might be able to point you to the right direction. Thanks.

@SorraTheOrc
Copy link
Contributor

Hi @ChrisLopezUK,

If you cloned the repo and made your changes there then you already did 95% of the work - thank you for that. We'd love to merge these changes in. The overall process is in the Understanding the GitHub flow.

The last mile is to issue a pull request against this repo. It sounds like you cloned this repo and made the changes locally, you have not already pushed the changes to a fork on Github. Assuming this is the case here is what you need to do (before following these steps assume I have made at least one error and thus copy your local files to a backup directory before starting).

  1. Create a fork of this repo (short version, click the Fork button top right, longer version in docs

  2. Make your fork the origin for your local clone (short version below, or docs

git remote set-url origin YOUR_REPO
  1. Commit the changes locally. Please ensure only changes relevant to this issue are included.
git add CHANGED_FILES
git commit -m "Adding HTTPS redirection on App Gateway"
  1. Push your changes to your fork (docs)
git push
  1. Create a pull request against this repo and referencing this issue in the comment with "Fixes Add HTTP -> HTTPS redirection on App Gateway config #102" (this will tag the PR with this issue and vice-versa) see https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

From there we will review the changes, possibly with a few requests for improvement and eventually we should be able to merge.

Thank you for your contribution, we truly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants