-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP -> HTTPS redirection on App Gateway config #102
Comments
Hi @hosungsmsft. I think I have nailed this issue. In addition I ammended the templates to allow for a conditional AppGW V2 deployment (which is a huge improvement over V1). Not sure how to contribute. I took a clone of the repo and made a separate branch. Not sure what to do now. Any tips? |
Sorry @ChrisLopezUK , I no longer work at Microsoft on this project. @rgardler might be able to point you to the right direction. Thanks. |
Hi @ChrisLopezUK, If you cloned the repo and made your changes there then you already did 95% of the work - thank you for that. We'd love to merge these changes in. The overall process is in the Understanding the GitHub flow. The last mile is to issue a pull request against this repo. It sounds like you cloned this repo and made the changes locally, you have not already pushed the changes to a fork on Github. Assuming this is the case here is what you need to do (before following these steps assume I have made at least one error and thus copy your local files to a backup directory before starting).
From there we will review the changes, possibly with a few requests for improvement and eventually we should be able to merge. Thank you for your contribution, we truly appreciate it. |
#98 added the Azure App Gateway support (fixing #31), but it lacks the http://siteurl -> https://siteurl redirection, which should be very easy with an Azure App Gateway example (doc). Community contribution would be great on things like this.
The text was updated successfully, but these errors were encountered: