Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SSL certs #14

Closed
SorraTheOrc opened this issue Jan 22, 2018 · 2 comments · Fixed by #75
Closed

Add support for SSL certs #14

SorraTheOrc opened this issue Jan 22, 2018 · 2 comments · Fixed by #75
Labels
enhancement New feature or request Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.

Comments

@SorraTheOrc
Copy link
Contributor

At present the deployment uses self-signed SSL certs. In order to update those certs one has to upload them to the server after deployment. It would be better to allow the cert to be provided/created at deployment if possible.
@SorraTheOrc SorraTheOrc added enhancement New feature or request Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves. labels Jan 22, 2018
@SorraTheOrc
Copy link
Contributor Author

We should use KeyVault and manage rotation of keys.

@SorraTheOrc SorraTheOrc added Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP. and removed Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves. labels Mar 21, 2018
@hosungsmsft hosungsmsft mentioned this issue Apr 9, 2018
Open
@hosungsmsft
Copy link

Created a separate issue (#74) for cert auto-rotation, as it currently needs to be done after the deployment.

@hosungsmsft hosungsmsft mentioned this issue Apr 9, 2018
Merged
hosungsmsft pushed a commit that referenced this issue Apr 9, 2018
Merge pull request #75 from Azure/hs-ssl-cert
f1690f2 
Allow customer's SSL cert to be specified at deployment time (fixes #14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow customer's SSL cert to be specified at deployment time (fixes #14) Azure/Moodle
2 participants
@SorraTheOrc @hosungsmsft