Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean string conversion case #793

Closed
BernieWhite opened this issue Jun 3, 2021 · 0 comments · Fixed by #795
Closed

Boolean string conversion case #793

BernieWhite opened this issue Jun 3, 2021 · 0 comments · Fixed by #795
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BernieWhite
Copy link
Collaborator

Description of the issue

When a bool is converted to a string the default .NET type converter has a different behaviour than ARM.

For example:

  • ARM: string(true()) = True, string(false()) = False
  • .NET: true = true, false = false.

To Reproduce

Steps to reproduce the issue:

{
    "$schema": "https://schema.management.azure.com/schemas/2019-08-01/tenantDeploymentTemplate.json#",
    "contentVersion": "1.0.0.0",
    "variables": {
        "lookup": {
            "True": {
                "value": "True"
            },
            "true": {
                "value": "true"
            },
            "false": {
                "value": "false"
            }
        }
    },
    "resources": [
        {
            "type": "Namespace/resourceType",
            "apiVersion": "2020-05-01",
            "name": "resource",
            "location": "region",
            "properties": {
                "value1": "[variables('lookup')[string(empty(''))].value]",
                "value2": "[variables('lookup')[tolower(string(empty('')))].value]",
                "value3": "[variables('lookup')[string(not(empty('')))].value]"
            }
        }
    ]
}

Expected behaviour

Update string() function to use True and False for converted bool value instead of true and false.

Module in use and version:

  • Module: PSRule.Rules.Azure
  • Version: 1.4.0

Captured output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@BernieWhite BernieWhite added the bug Something isn't working label Jun 3, 2021
@BernieWhite BernieWhite added this to the v1.4.1 milestone Jun 3, 2021
@BernieWhite BernieWhite self-assigned this Jun 3, 2021
BernieWhite added a commit to BernieWhite/PSRule.Rules.Azure that referenced this issue Jun 3, 2021
@BernieWhite BernieWhite mentioned this issue Jun 3, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant