Fixed transparentDataEncryption property status to state

[Dylan-Prins]

PR Summary

PR Checklist

• PR has a meaningful title
• Summarized changes
• Change is not breaking
• This PR is ready to merge and is not Work in Progress
• Rule changes
  • Unit tests created/ updated
  • Rule documentation created/ updated
  • Link to a filed issue
  • Change log has been updated with change under unreleased section
• Other code changes
  • Unit tests created/ updated
  • Link to a filed issue
  • Change log has been updated with change under unreleased section

[BernieWhite]

@Dylan-Prins Thanks for the PR. Looks like there is a difference between various API versions or the provider documentation is wrong. The newer use state where the older is status. If we can verify that status was an error, happy to accept your change. Otherwise we should update it to accept either status or state as Enabled you can do this with an if block or using AnyOf.

If the later, to get the tests to pass we need to add an entry for database-C that uses the state property here:

PSRule.Rules.Azure/tests/PSRule.Rules.Azure.Tests/Resources.SQL.json

Lines 436 to 491 in ca694e0

	{
	"Name": "database-B",
	"ResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Sql/servers/server-A/databases/database-B",
	"ResourceName": "server-A/database-B",
	"ResourceType": "Microsoft.Sql/servers/databases",
	"Kind": "v12.0,user",
	"ResourceGroupName": "test-rg",
	"Location": "region",
	"SubscriptionId": "00000000-0000-0000-0000-000000000000",
	"Properties": {
	"edition": "Standard",
	"status": "Online",
	"serviceLevelObjective": "S2",
	"collation": "SQL_Latin1_General_CP1_CI_AS",
	"maxSizeBytes": "268435456000",
	"requestedServiceObjectiveName": "S2",
	"sampleName": null,
	"defaultSecondaryLocation": "region-B",
	"earliestRestoreDate": "2019-01-01T00:00:00Z",
	"elasticPoolName": null,
	"containmentState": 2,
	"readScale": "Disabled",
	"failoverGroupId": null,
	"zoneRedundant": false,
	"isUpgradeRequested": false
	},
	"resources": [
	{
	"ResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Sql/servers/server-A/databases/database-B/transparentDataEncryption/current",
	"Id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Sql/servers/server-A/databases/database-B/transparentDataEncryption/current",
	"Identity": null,
	"Kind": null,
	"Location": "region",
	"ManagedBy": null,
	"ResourceName": "current",
	"Name": "current",
	"ExtensionResourceName": null,
	"ParentResource": null,
	"Plan": null,
	"Properties": {
	"status": "Enabled"
	},
	"ResourceGroupName": "test-rg",
	"Type": "Microsoft.Sql/servers/databases/transparentDataEncryption",
	"ResourceType": "Microsoft.Sql/servers/databases/transparentDataEncryption",
	"ExtensionResourceType": null,
	"Sku": null,
	"Tags": null,
	"TagsTable": null,
	"SubscriptionId": "00000000-0000-0000-0000-000000000000",
	"CreatedTime": null,
	"ChangedTime": null,
	"ETag": null
	}
	]
	}

2014-04-01

latest

@ms-sambell Did you notice something similar?

[Dylan-Prins]

I see! I will add an if statement. How can I check on API-Version in the if statement?

[ghost]

All CLA requirements met.

[BernieWhite]

@Dylan-Prins Nice work on the test resource. I think your suggestion is better to conditionally detect based on API version, but there is some specific cases around it.

Based on your suggestion, I am fine with removing database-C and just updating database-B with state as an export from Azure will be using a newer API version the specific case we are testing should always be state.

[BernieWhite]

The property apiVersion will not exist if exported with in-flight scenarios, but latest API version should be used. We only need to catch the case when older IaC is used.

Suggested change

	$Assert.HasFieldValue($config, 'Properties.state', 'Enabled');
	if ($Assert.HasFieldValue($config, 'apiVersion', '2014-04-01').Result) {
	$Assert.HasFieldValue($config, 'Properties.status', 'Enabled');
	}
	else {
	$Assert.HasFieldValue($config, 'Properties.state', 'Enabled');
	}

[Dylan-Prins]

Ok, I have added the if statement, removed database-c and changed database-b to 'state'

[BernieWhite]

@Dylan-Prins Great, all good to go. I'll update the branch for main and merge. Thanks!