Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Application Gateway Availability Zone Rule #942

Merged
merged 7 commits into from Sep 9, 2021

Conversation

ArmaanMcleod
Copy link
Contributor

@ArmaanMcleod ArmaanMcleod commented Sep 8, 2021

PR Summary

Fix #928

Created a Azure.AppGw.AvailabilityZone rule for the following types:

  • Microsoft.Network/applicationGateways

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@ArmaanMcleod ArmaanMcleod requested a review from a team as a code owner September 8, 2021 10:15
@ArmaanMcleod
Copy link
Contributor Author

For some reason running the Rule docs task is not generating the rule changes for Azure.All, Azure.Default or Azure.Preview. Trying to see if my markdown files are incorrect or something.

@ArmaanMcleod ArmaanMcleod changed the title Appgw az rule Added Application Gateway Availability Zone Rule Sep 8, 2021
@BernieWhite
Copy link
Collaborator

@ArmaanMcleod could be a regression with PSRule v1.7.x are you running v1.7.1? If you are try v1.6.0.

@ArmaanMcleod
Copy link
Contributor Author

@ArmaanMcleod could be a regression with PSRule v1.7.x are you running v1.7.1? If you are try v1.6.0.

Ah that seems to fix it. Thanks @BernieWhite.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod Nice! All good to merge or add the config doc consolidation.

docs/setup/configuring-rules.md Outdated Show resolved Hide resolved
@BernieWhite
Copy link
Collaborator

@ArmaanMcleod Armaan Dhaliwal-McLeod FTE could be a regression with PSRule v1.7.x are you running v1.7.1? If you are try v1.6.0.

Did v1.7.1 resolve the issue? Or is there an untracked bug that we need to address in v1.7.x?

@ArmaanMcleod
Copy link
Contributor Author

@ArmaanMcleod Armaan Dhaliwal-McLeod FTE could be a regression with PSRule v1.7.x are you running v1.7.1? If you are try v1.6.0.

Did v1.7.1 resolve the issue? Or is there an untracked bug that we need to address in v1.7.x?

Yeah this was resolved by downgrading my PSRule from 1.7.1 to 1.6.0. I can probably create an issue about this. Basically only docs/en/rules/module.md and docs/en/rules/resource.md were only being generated with 1.7.1.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod Nice work! All good to merge.

@ArmaanMcleod ArmaanMcleod merged commit 2d20fee into Azure:main Sep 9, 2021
@ArmaanMcleod ArmaanMcleod deleted the appgw-az-rule branch September 9, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Gateway should use availability zones for regions that support it
2 participants