Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wiki] Updated 'Module Library' section to latest #3504

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated 'Module Library' section to latest

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 3, 2023 13:26
@AlexanderSehr AlexanderSehr self-assigned this Aug 3, 2023
@AlexanderSehr AlexanderSehr added the documentation Improvements or additions to documentation label Aug 3, 2023
@AlexanderSehr AlexanderSehr linked an issue Aug 3, 2023 that may be closed by this pull request
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 3, 2023 13:27
@ahmadabdalla
Copy link
Contributor

@AlexanderSehr are there PRs you'd like to be merged first before these doc ones get updated?

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr are there PRs you'd like to be merged first before these doc ones get updated?

Hey @ahmadabdalla, there aren't. We're trying to push this bad boy through asap. In theory we could wait for the singular change, but personally I think it doesn't make much of a difference.
cc: @eriqua

@eriqua
Copy link
Contributor

eriqua commented Aug 5, 2023

@AlexanderSehr are there PRs you'd like to be merged first before these doc ones get updated?

Hey @ahmadabdalla, there aren't. We're trying to push this bad boy through asap. In theory we could wait for the singular change, but personally I think it doesn't make much of a difference. cc: @eriqua

Should we merge these to dev or to main?

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr are there PRs you'd like to be merged first before these doc ones get updated?

Hey @ahmadabdalla, there aren't. We're trying to push this bad boy through asap. In theory we could wait for the singular change, but personally I think it doesn't make much of a difference. cc: @eriqua

Should we merge these to dev or to main?

That's my point. I think main is OK, as these are just docs updates that are not dependent on anything - as opposed to the module changes that all need to be done / merged in one go

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
AlexanderSehr and others added 2 commits August 6, 2023 21:40
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 4fdb0b9 into main Aug 8, 2023
8 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/3502_library branch August 8, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check & update 'The libarary'
3 participants