Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep module to create Front Door WAF Policy #3718

Conversation

rajeshkaremane
Copy link
Contributor

@rajeshkaremane rajeshkaremane commented Aug 25, 2023

Description

New module added to create WAF Policy for Front Door related to #3714

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rajeshkaremane, would you happen to have a successfully pipeline run handy to show that the code successfully passes all tests? For that you'd need an Azure Subscription that you set up as a target environment in your Fork.
If you don't have one available, we could also offer to rebase your PR to a dev branch on our end and test it in our environment. Please let us know. :)

@rajeshkaremane
Copy link
Contributor Author

Hey @rajeshkaremane, would you happen to have a successfully pipeline run handy to show that the code successfully passes all tests? For that you'd need an Azure Subscription that you set up as a target environment in your Fork. If you don't have one available, we could also offer to rebase your PR to a dev branch on our end and test it in our environment. Please let us know. :)

Hi @AlexanderSehr
I am happy for you to test in dev branch.

Thanks
Rajesh

@AlexanderSehr AlexanderSehr changed the base branch from main to users/alsehr/228005_DeployFrontDoorWAFRules_rajeshkaremane August 30, 2023 10:21
@AlexanderSehr AlexanderSehr merged commit e808a39 into Azure:users/alsehr/228005_DeployFrontDoorWAFRules_rajeshkaremane Aug 30, 2023
1 check passed
AlexanderSehr added a commit that referenced this pull request Aug 31, 2023
* Bicep module to create Front Door WAF Policy

* Added github pipeline and fixed suggestions

Co-authored-by: rajeshkaremane <142348849+rajeshkaremane@users.noreply.github.com>
@ppotturi ppotturi deleted the feature/rv/228005-DeployFrontDoorWAFRules branch September 12, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants