Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Bicep module to create Front Door WAF Policy (#3718) #3881

Merged
merged 7 commits into from
Aug 31, 2023
Merged

[Modules] Bicep module to create Front Door WAF Policy (#3718) #3881

merged 7 commits into from
Aug 31, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 30, 2023 •
edited

Description

cc: @rajeshkaremane

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@rajeshkaremane
Bicep module to create Front Door WAF Policy (#3718)
e808a39 
* Bicep module to create Front Door WAF Policy

* Added github pipeline and fixed suggestions
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 30, 2023 10:24
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Aug 30, 2023
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 30, 2023 10:48
AlexanderSehr and others added 3 commits August 31, 2023 10:20
@AlexanderSehr @ahmadabdalla
Update modules/network/front-door-web-application-firewall-policy/mai…
bb6f38d 
…n.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@AlexanderSehr @ahmadabdalla
Update modules/network/front-door-web-application-firewall-policy/mai…
7d2a60b 
…n.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@AlexanderSehr @ahmadabdalla
Update modules/network/front-door-web-application-firewall-policy/mai…
fd4a48f 
…n.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@AlexanderSehr AlexanderSehr merged commit f08a6e5 into main Aug 31, 2023
12 of 13 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/228005_DeployFrontDoorWAFRules_rajeshkaremane branch August 31, 2023 11:18
@rajeshkaremane rajeshkaremane mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

@rajeshkaremane rajeshkaremane rajeshkaremane approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexanderSehr @ahmadabdalla @rajeshkaremane