Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Diagnostic Settings to Modules #765

Merged
merged 18 commits into from
Dec 9, 2021

Conversation

senavar
Copy link
Contributor

@senavar senavar commented Dec 8, 2021

Change

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Updated the Log Analytics, SQL DB, and Storage Account modules to allow for the configuration of diagnostic settings

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

OperationalInsights: Workspaces

Sql: Servers

Storage: StorageAccounts

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @senavar, any chance you tested the code in pipelines? If so, could you do me a favor and add the pipeline badges to your PR summary for the pipelines to which you added the diagnostic settings?

@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Dec 8, 2021
@AlexanderSehr AlexanderSehr added [cat] modules category: modules enhancement New feature or request labels Dec 8, 2021
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Unit Test Results

  1 files  ±  0    1 suites  ±0   19s ⏱️ +5s
32 tests +28  32 ✔️ +28    0 💤 ±  0  0 ±0 
50 runs  +13  34 ✔️ +30  16 💤  - 17  0 ±0 

Results for commit 1d50d3d. ± Comparison against base commit d13ae5d.

This pull request removes 4 and adds 32 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [servers] should use on of the recent API version(s). Currently using [2017-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Storage/storageAccounts] Template schema should use HTTPS reference
…

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr merged commit 7042a06 into main Dec 9, 2021
@AlexanderSehr AlexanderSehr deleted the users/senavar/diagSettingsUpdate branch December 9, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module: Check modules for missing diagnostic settings implementation & add it
2 participants