Fix Travis special checks for distro and remove useless cgroup tests #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgombar
requested review from
kevinclark19a,
larohra,
narrieta and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1959 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 85 85
Lines 11985 11985
Branches 1677 1677
========================================
Hits 8350 8350
Misses 3263 3263
Partials 372 372 Continue to review full report at Codecov.
|
pgombar
commented
Jul 22, 2020
| return ret | ||
|
|
||
|
|
||
| def is_trusty_in_travis(): |
There was a problem hiding this comment.
This wasn't used anywhere.
pgombar
commented
Jul 22, 2020
| return Ubuntu16OSUtil() | ||
|
|
||
|
|
||
| def mock_get_osutil(*args): |
There was a problem hiding this comment.
The whole method is obsolete since there is no need to do custom checks in Travis anymore.
ZhidongPeng
previously approved these changes
Jul 22, 2020
larohra
reviewed
Jul 22, 2020
larohra
previously approved these changes
Jul 22, 2020
kevinclark19a
previously approved these changes
Jul 23, 2020
pgombar
dismissed stale reviews from kevinclark19a, larohra, and ZhidongPeng
via
8d89e0e
pgombar
changed the title
kevinclark19a
approved these changes
Jul 23, 2020
narrieta
approved these changes
Jul 23, 2020
larohra
approved these changes
Jul 23, 2020
pgombar
added a commit
to pgombar/WALinuxAgent
that referenced
this pull request
Jul 23, 2020
pgombar
added a commit
to pgombar/WALinuxAgent
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had special checks for distro resolution in Travis since Ubuntu 14.04 (trusty) was resolving to something else (debian/stretch). Unit tests started failing since Travis updated their OS environment variables and also fixed the distro resolution, so our custom solution is not needed anymore.
os.environ['_system_name']andos.environ['_system_version']are deprecated, now it's just'TRAVIS_DIST': 'xenial'PR information
Quality of Code and Contribution Guidelines