Use tmp_dir instead of data_dir #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
kevinclark19a,
larohra,
pgombar and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1968 +/- ##
========================================
Coverage 69.59% 69.60%
========================================
Files 85 85
Lines 11998 11998
Branches 1677 1677
========================================
+ Hits 8350 8351 +1
+ Misses 3276 3273 -3
- Partials 372 374 +2
Continue to review full report at Codecov.
|
kevinclark19a
approved these changes
Jul 30, 2020
larohra
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were writing to the data_dir; I changed them to write to the tmp_dir.