Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall unregistered extensions #1970

Merged
merged 10 commits into from
Aug 4, 2020

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Jul 31, 2020

Description

Currently the Agent doesn't uninstall extensions if the extension was unregistered from PIR. This PR handles that scenario - Issue #1449
Additionally did some code cleanup in the PR.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #1970 into develop will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1970      +/-   ##
===========================================
+ Coverage    69.63%   69.67%   +0.04%     
===========================================
  Files           85       85              
  Lines        12024    12028       +4     
  Branches      1680     1680              
===========================================
+ Hits          8373     8381       +8     
+ Misses        3275     3273       -2     
+ Partials       376      374       -2     
Impacted Files Coverage Δ
azurelinuxagent/ga/exthandlers.py 86.74% <80.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d949a7a...776df7d. Read the comment docs.

kevinclark19a
kevinclark19a previously approved these changes Aug 4, 2020
narrieta
narrieta previously approved these changes Aug 4, 2020
@larohra larohra dismissed stale reviews from narrieta and kevinclark19a via 3bf2a78 August 4, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants