-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninstall unregistered extensions #1970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larohra
requested review from
kevinclark19a,
narrieta,
pgombar and
ZhidongPeng
as code owners
July 31, 2020 22:16
Codecov Report
@@ Coverage Diff @@
## develop #1970 +/- ##
===========================================
+ Coverage 69.63% 69.67% +0.04%
===========================================
Files 85 85
Lines 12024 12028 +4
Branches 1680 1680
===========================================
+ Hits 8373 8381 +8
+ Misses 3275 3273 -2
+ Partials 376 374 -2
Continue to review full report at Codecov.
|
narrieta
reviewed
Aug 4, 2020
kevinclark19a
previously approved these changes
Aug 4, 2020
narrieta
previously approved these changes
Aug 4, 2020
… uninstall-unregistered-ext
narrieta
approved these changes
Aug 4, 2020
pgombar
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the Agent doesn't uninstall extensions if the extension was unregistered from PIR. This PR handles that scenario - Issue #1449
Additionally did some code cleanup in the PR.
PR information
Quality of Code and Contribution Guidelines