Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify deny-listing logic of the Agent #2487

Merged
merged 8 commits into from Jan 28, 2022
Merged

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Jan 26, 2022

Description

This PR tackles the following -

  • Currently the agent blacklists the agent in 3 scenarios. This PR reduces it to a single place
  • Add a new flag (reason) in the error.json file to differentiate between new blacklisting logic and old
  • Un-blacklist the agents that were blacklisted by the legacy agents in order to clean the state

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #2487 (fc9a985) into develop (b27e475) will decrease coverage by 0.00%.
The diff coverage is 76.74%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2487      +/-   ##
===========================================
- Coverage    72.01%   72.01%   -0.01%     
===========================================
  Files          101      101              
  Lines        15100    15121      +21     
  Branches      2399     2403       +4     
===========================================
+ Hits         10875    10889      +14     
- Misses        3737     3745       +8     
+ Partials       488      487       -1     
Impacted Files Coverage Δ
azurelinuxagent/ga/update.py 88.56% <76.74%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27e475...fc9a985. Read the comment docs.

narrieta
narrieta previously approved these changes Jan 27, 2022
kevinclark19a
kevinclark19a previously approved these changes Jan 27, 2022
# Conflicts:
#	azurelinuxagent/ga/update.py
#	tests/ga/test_update.py
@larohra larohra dismissed stale reviews from kevinclark19a and narrieta via d5bcd00 January 28, 2022 09:59
@larohra larohra merged commit 55be326 into Azure:develop Jan 28, 2022
@larohra larohra deleted the restrict-bl branch January 28, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants