Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suppression from warning: "need a bytes-like object, NoneType found" #2529

Merged

Conversation

kevinclark19a
Copy link
Contributor

@kevinclark19a kevinclark19a commented Mar 9, 2022

Description

The suppression was added to ignore errors produced when the agent receives an empty goal state. Those errors were fixed a while ago (initial fix in #2016, then added back in #2141 after those changes were reverted).

This PR removes the suppression so that we can catch errors with the same signature.

from DCRv2 agent log ignore list
@kevinclark19a kevinclark19a changed the title Remove suppression from warning: Remove suppression from warning: "need a bytes-like object, NoneType found" Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2529 (0e2e848) into develop (2027103) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2529      +/-   ##
===========================================
+ Coverage    71.96%   72.01%   +0.05%     
===========================================
  Files          102      102              
  Lines        15188    15188              
  Branches      2403     2403              
===========================================
+ Hits         10930    10938       +8     
+ Misses        3775     3770       -5     
+ Partials       483      480       -3     
Impacted Files Coverage Δ
azurelinuxagent/common/event.py 86.03% <0.00%> (+0.67%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 91.43% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2027103...0e2e848. Read the comment docs.

@kevinclark19a kevinclark19a merged commit 3eda39b into Azure:develop Mar 9, 2022
@kevinclark19a kevinclark19a deleted the cleanup-ignore-list-dcrv2 branch March 9, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants