Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py to cater for all RHEL 8 versions #2532

Merged
merged 3 commits into from Mar 18, 2022
Merged

Update setup.py to cater for all RHEL 8 versions #2532

merged 3 commits into from Mar 18, 2022

Conversation

jabofh
Copy link
Contributor

@jabofh jabofh commented Mar 14, 2022

  • Testing for version.startswith("8.2") breaks on RHEL versions later than 8.2
  • RHEL 8.0, not 8.2, changed the default Python version to 3.x

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

-  Testing for version.startswith("8.2") breaks on RHEL versions later than 8.2
-  RHEL 8.0, not 8.2, changed the default Python version to 3.x
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #2532 (495e145) into develop (eb0c056) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2532      +/-   ##
===========================================
+ Coverage    71.98%   72.02%   +0.03%     
===========================================
  Files          102      102              
  Lines        15197    15197              
  Branches      2404     2404              
===========================================
+ Hits         10940    10945       +5     
+ Misses        3776     3774       -2     
+ Partials       481      478       -3     
Impacted Files Coverage Δ
azurelinuxagent/ga/collect_telemetry_events.py 91.43% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0c056...495e145. Read the comment docs.

@nagworld9
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants