Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update current memory usage check on log collector cgroup #2658

Merged
merged 1 commit into from Aug 30, 2022

Conversation

nagworld9
Copy link
Contributor

@nagworld9 nagworld9 commented Aug 24, 2022

Description

Systemd cgroup slice somehow gets left behind not cleaned up after logcollector finished. Due to this, max_memory_usage counter not cleaned up for next log collector run. When we check for memory limit, we may get old value and disable the log collector based on that which is not right. So, I updated that logic and consider only memory.stat(RSS+cache+SWAP) to check current memory_usage.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #2658 (100a58a) into develop (3aebcdd) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2658      +/-   ##
===========================================
- Coverage    71.97%   71.97%   -0.01%     
===========================================
  Files          103      103              
  Lines        15692    15688       -4     
  Branches      2486     2485       -1     
===========================================
- Hits         11295    11291       -4     
  Misses        3881     3881              
  Partials       516      516              
Impacted Files Coverage Δ
azurelinuxagent/ga/collect_logs.py 81.15% <0.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nagworld9 nagworld9 changed the title update max memory usage check on log collector cgroup update current memory usage check on log collector cgroup Aug 24, 2022
@nagworld9 nagworld9 merged commit 51b27a1 into Azure:develop Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants