Require HostGAPlugin >= 133 for Fast Track #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
commented
Sep 29, 2022
| @@ -491,7 +491,7 @@ def format_message(msg): | |||
| try: | |||
| # Raise if VmSettings are not supported, but check again periodically since the HostGAPlugin could have been updated since the last check | |||
| # Note that self._host_plugin_supports_vm_settings can be None, so we need to compare against False | |||
| if self._supports_vm_settings == False and self._supports_vm_settings_next_check > datetime.datetime.now(): | |||
There was a problem hiding this comment.
did this change to silence a Pycharm warning
Codecov Report
@@ Coverage Diff @@
## release-2.9.0.0 #2673 +/- ##
=================================================
Coverage 71.95% 71.95%
=================================================
Files 103 103
Lines 15681 15681
Branches 2486 2245 -241
=================================================
Hits 11284 11284
Misses 3880 3880
Partials 517 517
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nagworld9
approved these changes
Sep 30, 2022
narrieta
added a commit
to narrieta/WALinuxAgent
that referenced
this pull request
Sep 30, 2022
Co-authored-by: narrieta <narrieta> (cherry picked from commit a65135f)
narrieta
added a commit
that referenced
this pull request
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostGAPlugin < 133 will fail requests to download extension artifacts when using Fast Track.