Support int type for eventPid and eventTid fields #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
nagworld9
commented
Mar 14, 2023
| @@ -58,6 +58,8 @@ class ExtensionEventSchema(object): | |||
| "EventTid":"2", | |||
| "OperationId":"Guid (str)" | |||
| } | |||
|
|
|||
| From next version(2.10+) we accept integer values for EventPid and EventTid fields. But we still support string type for backward compatability | |||
There was a problem hiding this comment.
Assumed this go in next release and version would be 2.10
Codecov Report
@@ Coverage Diff @@
## develop #2786 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 104 104
Lines 15851 15857 +6
Branches 2271 2273 +2
========================================
+ Hits 11412 11417 +5
Misses 3915 3915
- Partials 524 525 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
reviewed
Mar 14, 2023
|
|
||
| clean_string = lambda x: x.strip() if x is not None else x | ||
| def _clean_value(k, v): | ||
| if v is not None: |
There was a problem hiding this comment.
if v is None, _clean_value will return None and the conversion below will raise an exception
There was a problem hiding this comment.
Sorry, where? I kept it same as we have today so that downstream code will work like before.
There was a problem hiding this comment.
never mind, you are converting the key, not the value
narrieta
approved these changes
Mar 14, 2023
maddieford
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today we only support string value for eventPid and EventTid. As these fields are ids and ids are generally numeric in nature, so changing logic to support int values too.
Issue #
PR information
Quality of Code and Contribution Guidelines