Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing crypt with legacycrypt #2994

Closed
wants to merge 1 commit into from
Closed

Conversation

st13g
Copy link

@st13g st13g commented Dec 11, 2023

Description

Issue # https://bugzilla.redhat.com/show_bug.cgi?id=2246085

the package fails to build with python 3.13 due to crypt module is going to be deprecated, so to address this issue and not break anything in the code or how this treat the hashing, this PR is replacing crypt with legacycrypt


PR information

  • [x ] The title of the PR is clear and informative.
  • [ x] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [x ] If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@nagworld9
Copy link
Contributor

nagworld9 commented Dec 27, 2023

@st13g Thanks for the fix but we have a work item to validate whole agent against python 3.13 and will take this change when we get to that work item.

@narrieta
Copy link
Member

@st13g Thank you for your contribution. This has been addressed by #3070

@narrieta narrieta closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants