Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more hooks #510

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Adds more hooks #510

merged 1 commit into from
Dec 9, 2016

Conversation

caphrim007
Copy link
Contributor

@caphrim007 caphrim007 commented Dec 8, 2016 •
edited

Added more hooks and things to bigip osutil code

  • some notes in code
  • some small refactors
  • added del_account hook
  • added _format_single_interface_name for easier mock unit tests
  • added route_add hook
  • added tests for device_for_ide_port and route_add

@caphrim007
Adds more hooks
2a68f73 
simplified some code. Added the delete user hook. collapsed
some keyword args
hglkrijger
hglkrijger approved these changes Dec 9, 2016
View reviewed changes
Copy link
Member

@hglkrijger hglkrijger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hglkrijger
Copy link
Member

@brendandixon any other feedback?

@brendandixon
Copy link
Contributor

I'm good.

@hglkrijger hglkrijger merged commit edba18b into Azure:master Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hglkrijger hglkrijger hglkrijger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caphrim007 @hglkrijger @brendandixon @msftclas