Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a reboot issue when updating RDMA driver on ND host update #594

Merged
merged 4 commits into from
Mar 6, 2017

Conversation

longlimsft
Copy link
Collaborator

No description provided.

@szarkos
Copy link
Contributor

szarkos commented Mar 2, 2017

Bump?

@hglkrijger
Copy link
Member

@rjschwei - any further comments on this?

@rjschwei
Copy link
Contributor

rjschwei commented Mar 3, 2017

My gut still tells me that using "--first-time" can/will get us into a situation where we "break" the system unnecessarily for the user, meaning an error condition is generated when we should not generate such an error condition. However, given that I have no argumentative/logical proof of this and it is not fair to block code changes based on gut-feel I'll have to live with the nagging feeling. We can always fix it when the issue shows up.

@brendandixon
Copy link
Contributor

@rjschwei Fair point. But that sounds like a rare (?) case and, after the reboot, all will be good, no?

In any case, LGTM.

@rjschwei
Copy link
Contributor

rjschwei commented Mar 4, 2017

@brendandixon yes, probably rare. Not sure if the reboot we eliminate the need for manual intervention.

@hglkrijger hglkrijger merged commit 9b7079b into Azure:master Mar 6, 2017
@hglkrijger hglkrijger added this to the v2.2.6 milestone Mar 6, 2017
@longlimsft longlimsft deleted the module_fix branch March 7, 2017 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants