Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

chore: promote crd to apiextensions.k8s.io/v1 and remove role assignments after e2e test #1035

Merged
merged 1 commit into from
Apr 15, 2021
Merged

chore: promote crd to apiextensions.k8s.io/v1 and remove role assignments after e2e test #1035

merged 1 commit into from
Apr 15, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Apr 8, 2021 •
edited
Loading

Signed-off-by: Ernest Wong chuwon@microsoft.com

Reason for Change:

fixes #661
fixes #994

  • use controller-gen to generate YAML files for our CRDs
  • existing users with 1.16+ clusters should not be affected by this PR since kube-apiserver already converts CRDs with apiVersion of v1beta1 to v1 automatically
  • helm 3 does not re-configure the CRDs during an upgrade (meaning new fields like openAPIV3Schema won't be added), whereas kubectl apply -f does re-configure the CRDs to include new fields added in this PR
  • existing CRDs data should be persisted unless the user explicitly runs kubectl delete crds

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable). See test standard for more details.
  • ran make precommit

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@chewong chewong requested a review from aramase April 8, 2021 18:39
@chewong chewong changed the title chore: promote crd to apiextensions.k8s.io/v1 chore: promote crd to apiextensions.k8s.io/v1 and remove role assignments after e2e test Apr 8, 2021
@chewong
Copy link
Contributor Author

chewong commented Apr 14, 2021

@aramase this PR is ready for review

aramase
aramase reviewed Apr 14, 2021
View reviewed changes
.pipelines/templates/role-assignment.yml Outdated Show resolved Hide resolved
manifest_staging/charts/aad-pod-identity/values.yaml Outdated Show resolved Hide resolved
pkg/apis/aadpodidentity/v1/types.go Show resolved Hide resolved
test/e2e/backward_compat_test.go Show resolved Hide resolved
@chewong chewong requested a review from aramase April 14, 2021 21:28
chore: promote crd to apiextensions.k8s.io/v1
555b9ad 
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@chewong chewong enabled auto-merge (rebase) April 14, 2021 23:27
@chewong chewong disabled auto-merge April 15, 2021 16:32
@chewong chewong merged commit 38c46a4 into Azure:master Apr 15, 2021
@chewong chewong deleted the fix-661 branch April 15, 2021 16:33
@aramase aramase mentioned this pull request Apr 22, 2021
Closed
statbit pushed a commit to adobe-platform/aad-pod-identity that referenced this pull request Sep 30, 2021
chore: promote crd to apiextensions.k8s.io/v1 (Azure#1035)
4ff39b5 
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aramase aramase aramase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chewong @aramase