Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

docs: add note about specifying which identity to use #869

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

JasonTheDeveloper
Copy link
Contributor

@JasonTheDeveloper JasonTheDeveloper commented Nov 16, 2020

Reason for Change:
I've added an additional note to the bottom of the section A pod using multiple AzureIdentities found in Best Practices. We found that although it is possible to allow a pod to utilise multiple identities, the documentation fails to mention you need to specify which identity should be use for a particular workload.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable). See test standard for more details.
  • ran make precommit

Issue Fixed: N/A.

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

No.

Notes for Reviewers:

N/A.

Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasonTheDeveloper Thank you for the PR 🎉

lgtm

@aramase aramase merged commit 45769a8 into Azure:master Nov 16, 2020
@JasonTheDeveloper JasonTheDeveloper deleted the docs/multiple_id branch November 16, 2020 23:46
statbit pushed a commit to adobe-platform/aad-pod-identity that referenced this pull request Sep 30, 2021
* docs: add note about specifying which identity to use

* docs: applying suggested changes

Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>

Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants