Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for private IPs, dns-name-label no longer required #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davemaul
Copy link

Fixes #53

@ghost
Copy link

ghost commented Jan 13, 2022

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Jan 27, 2022
@davemaul
Copy link
Author

Push ;)

@github-actions github-actions bot removed the idle label Jan 28, 2022
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Feb 11, 2022
@davemaul
Copy link
Author

Push

@github-actions github-actions bot removed the idle label Feb 14, 2022
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Feb 28, 2022
@davemaul
Copy link
Author

davemaul commented Mar 1, 2022

Push

@github-actions github-actions bot removed the idle label Mar 1, 2022
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Mar 15, 2022
@SvenAelterman
Copy link

Isn't using network profiles for virtual network integration deprecated now?

@github-actions github-actions bot removed the idle label Mar 21, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Apr 5, 2022
@artem-troitskiy
Copy link

Would be great if this can be reviewed and, if everything looks fine, merged. This would save a lot of trouble at least for me :)

@github-actions github-actions bot removed the idle label Apr 7, 2022
@troyyyang
Copy link

@BALAGA-GAYATRI any chance this will be reviewed?

@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Apr 29, 2022
@troyyyang
Copy link

🥺
👉👈

@github-actions github-actions bot removed the idle label May 5, 2022
@davemaul
Copy link
Author

davemaul commented May 9, 2022

This is ridiculous 🤣

@troyyyang
Copy link

i tried using the azi cli action as a workaround, but then his this issue

Azure/azure-cli#7593

@BALAGA-GAYATRI
Copy link
Contributor

BALAGA-GAYATRI commented May 10, 2022

@davemaul sorry for the delayed response. In the last quarter, we haven't planned to make any investments on this action's enhancements. This PR shall be discussed and reviewed accordingly. I also want to understand about the testing process that was followed for committing to this change. Thanks :)

@davemaul
Copy link
Author

I tested it with a project of ours. Nothing more to say. :D The change is minimal. However, it doesn't matter for us anymore because we dumped the usage of this action due to lack of maintenance. 😉

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Jun 3, 2022
@mattGLB
Copy link

mattGLB commented Dec 12, 2022

Hello, when can we expect this update to be pushed?

@AnguIar
Copy link

AnguIar commented Feb 3, 2024

@davemaul sorry for the delayed response. In the last quarter, we haven't planned to make any investments on this action's enhancements. This PR shall be discussed and reviewed accordingly. I also want to understand about the testing process that was followed for committing to this change. Thanks :)

Is there any update? This is a simple yet important feature for us.

@stan-spotts
Copy link

@davemaul sorry for the delayed response. In the last quarter, we haven't planned to make any investments on this action's enhancements. This PR shall be discussed and reviewed accordingly. I also want to understand about the testing process that was followed for committing to this change. Thanks :)

I don't understand such decisions. Microsoft has invested a ton in GitHub, and it's in their interest to ensure that actions that work with all of the resource types/services on Azure are working and current. And if this isn't the case, at least commit the time to review changes from the public and approve valid pull requests.

This is doing nothing but destroying the developer experience and belief that Microsoft supports the developer and devops community. I had to live through this as a blue badge in DPE when Microsoft abandoned ISV's in the 90's and spent years having to help gain back the trust. How can Microsoft not have learned from this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting ip-address to Private causes an error
9 participants