Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Extract common utils to separate packages #2010

Merged
merged 1 commit into from Jan 9, 2018
Merged

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Jan 8, 2018

What this PR does / why we need it:

Extract common utils to separate packages and remove direct dependency of translator, e.g.

  • Transformer.NormalizeForK8sVMASScalingUp
  • armhelpers.GetVMNameIndex

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1975

Special notes for your reviewer:

Release note:

NONE

@andyzhangx
Copy link
Contributor

andyzhangx commented Jan 8, 2018

@JiangtianLi @jackfrancis

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit 2acafe6 into Azure:master Jan 9, 2018
@feiskyer feiskyer deleted the util branch January 9, 2018 04:31
@feiskyer
Copy link
Member Author

feiskyer commented Jan 9, 2018

@jackfrancis thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make kubernetes utils reusable for external packages
3 participants