Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Remove trailing whitespaces #2495

Merged
merged 9 commits into from
Mar 27, 2018
Merged

Remove trailing whitespaces #2495

merged 9 commits into from
Mar 27, 2018

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Mar 20, 2018

Did a bit of clean-up cause some editors like VSCODE remove trailing whitespaces on save and it makes diff fatter.

Sylvain Rabot added 2 commits March 20, 2018 11:55
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
@sylr sylr changed the title Remove trailing whitespaces in parts/ Remove trailing whitespaces Mar 20, 2018
@jackfrancis
Copy link
Member

@sylr I'm fine with this. I'd like to have @yakman2020 sign off as well, as I know he's doing some DC/OS work that will touch these same files.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the change to examples/kubernetes-labels/images/kubernetesnodelabels.png intentional?

@sylr
Copy link
Contributor Author

sylr commented Mar 23, 2018

@CecileRobertMichon not really 🤦‍♂️

Sylvain Rabot added 7 commits March 23, 2018 16:58
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
@sylr
Copy link
Contributor Author

sylr commented Mar 26, 2018

@yakman2020 Are you down with this ?

@sylr
Copy link
Contributor Author

sylr commented Mar 27, 2018

@jackfrancis can we merge this despite the lack of answer of @yakman2020 ?

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending E2E

@jackfrancis jackfrancis merged commit 00fd963 into Azure:master Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants